From 2208b5e1675b5505fd2be9c200696d190283d760 Mon Sep 17 00:00:00 2001 From: M-A Date: Fri, 14 Feb 2025 17:44:09 -0500 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Olivier Mengué --- inky/impression.go | 2 ++ inky/types.go | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/inky/impression.go b/inky/impression.go index 28d0fe7..1edbe10 100644 --- a/inky/impression.go +++ b/inky/impression.go @@ -406,6 +406,8 @@ func (d *DevImpression) resetUC() error { } func (d *DevImpression) resetAC() error { + // Reference code: https://github.com/pimoroni/inky/blob/a7d380231cc5fac754243b8d66d2c5674c1bd1ac/inky/inky_ac073tc1a.py#L229 + if err := d.cycleResetGPIO(); err != nil { return err } diff --git a/inky/types.go b/inky/types.go index c0c863c..41939d1 100644 --- a/inky/types.go +++ b/inky/types.go @@ -40,7 +40,7 @@ func (m *Model) Set(s string) error { case "IMPRESSION73": *m = IMPRESSION73 default: - return fmt.Errorf("unknown model %q: expected PHAT, PHAT2, WHAT, IMPRESSION4 or IMPRESSION57 or IMPRESSION73", s) + return fmt.Errorf("unknown model %q: expected PHAT, PHAT2, WHAT, IMPRESSION4, IMPRESSION57 or IMPRESSION73", s) } return nil }