From 2ac43be45e1bec696a0a23892a01f928ac4185b9 Mon Sep 17 00:00:00 2001 From: Marc-Antoine Ruel Date: Fri, 4 Dec 2020 19:46:14 -0500 Subject: [PATCH] mcp23xxx: fix invalid value; add link to datasheet See page 12, Table 3-1, and page 17 table 3-5 (bank select is zero on reset). --- experimental/devices/mcp23xxx/doc.go | 4 ++++ experimental/devices/mcp23xxx/mcp23xxx.go | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/experimental/devices/mcp23xxx/doc.go b/experimental/devices/mcp23xxx/doc.go index 3f9b6ba..4a831a0 100644 --- a/experimental/devices/mcp23xxx/doc.go +++ b/experimental/devices/mcp23xxx/doc.go @@ -3,4 +3,8 @@ // that can be found in the LICENSE file. // Package mcp23xxx provides driver for the MCP23 family of IO extenders +// +// Datasheet +// +// https://ww1.microchip.com/downloads/en/DeviceDoc/20001952C.pdf package mcp23xxx diff --git a/experimental/devices/mcp23xxx/mcp23xxx.go b/experimental/devices/mcp23xxx/mcp23xxx.go index 5a75117..59323a5 100644 --- a/experimental/devices/mcp23xxx/mcp23xxx.go +++ b/experimental/devices/mcp23xxx/mcp23xxx.go @@ -152,7 +152,7 @@ func mcp23x178ports(devicename string, ra registerAccess) []port { // interrupt handling registers gpinten: ra.define(0x05), - intcon: ra.define(0x0B), + intcon: ra.define(0x09), intf: ra.define(0x0F), intcap: ra.define(0x11), supportInterrupt: true,