From 3368c35ef7f60dd462aaaf23767900a8911eeff5 Mon Sep 17 00:00:00 2001 From: M-A Date: Thu, 8 Dec 2016 21:28:50 -0500 Subject: [PATCH] gpio: Rename Up and Down to PullUp and PullDown. (#93) This should make it more approachable for first time users. --- devices/tm1637/tm1637.go | 2 +- experimental/devices/bitbang/i2c.go | 10 +++++----- experimental/devices/bitbang/spi.go | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/devices/tm1637/tm1637.go b/devices/tm1637/tm1637.go index c428470..184b354 100644 --- a/devices/tm1637/tm1637.go +++ b/devices/tm1637/tm1637.go @@ -168,7 +168,7 @@ func (d *Dev) writeByte(b byte) (bool, error) { d.data.Out(gpio.Low) time.Sleep(clockHalfCycle) // TODO(maruel): Add. - //if err := d.data.In(gpio.Up, gpio.None); err != nil { + //if err := d.data.In(gpio.PullUp, gpio.None); err != nil { // return false, err //} d.clk.Out(gpio.High) diff --git a/experimental/devices/bitbang/i2c.go b/experimental/devices/bitbang/i2c.go index 725b8a1..fe08013 100644 --- a/experimental/devices/bitbang/i2c.go +++ b/experimental/devices/bitbang/i2c.go @@ -118,14 +118,14 @@ func (i *I2C) SDA() gpio.PinIO { func New(clk gpio.PinIO, data gpio.PinIO, speedHz int) (*I2C, error) { // Spec calls to idle at high. Page 8, section 3.1.1. // Set SCL as pull-up. - if err := clk.In(gpio.Up, gpio.None); err != nil { + if err := clk.In(gpio.PullUp, gpio.None); err != nil { return nil, err } if err := clk.Out(gpio.High); err != nil { return nil, err } // Set SDA as pull-up. - if err := data.In(gpio.Up, gpio.None); err != nil { + if err := data.In(gpio.PullUp, gpio.None); err != nil { return nil, err } if err := data.Out(gpio.High); err != nil { @@ -196,11 +196,11 @@ func (i *I2C) writeByte(b byte) (bool, error) { // 9th clock is ACK. i.sleepHalfCycle() // SCL was already set as pull-up. PullNoChange - if err := i.scl.In(gpio.Up, gpio.None); err != nil { + if err := i.scl.In(gpio.PullUp, gpio.None); err != nil { return false, err } // SDA was already set as pull-up. - if err := i.sda.In(gpio.Up, gpio.None); err != nil { + if err := i.sda.In(gpio.PullUp, gpio.None); err != nil { return false, err } // Implement clock stretching, the device may keep the line low. @@ -227,7 +227,7 @@ func (i *I2C) writeByte(b byte) (bool, error) { // Lasts 9 cycles. func (i *I2C) readByte() (byte, error) { var b byte - if err := i.sda.In(gpio.Up, gpio.None); err != nil { + if err := i.sda.In(gpio.PullUp, gpio.None); err != nil { return b, err } for x := 0; x < 8; x++ { diff --git a/experimental/devices/bitbang/spi.go b/experimental/devices/bitbang/spi.go index a1591d6..b57e5bb 100644 --- a/experimental/devices/bitbang/spi.go +++ b/experimental/devices/bitbang/spi.go @@ -138,7 +138,7 @@ func NewSPI(clk, mosi gpio.PinOut, miso gpio.PinIn, cs gpio.PinOut, speedHz int6 return nil, err } if miso != nil { - if err := miso.In(gpio.Up, gpio.None); err != nil { + if err := miso.In(gpio.PullUp, gpio.None); err != nil { return nil, err } }