From 6cd1bba85417c75ddab35111c5220ba0c59da86e Mon Sep 17 00:00:00 2001 From: Marc-Antoine Ruel Date: Sun, 19 May 2019 09:29:16 -0400 Subject: [PATCH] travis: start using ineffassign It actually found two bugs. --- devices/lirc/lirc.go | 3 +++ experimental/devices/mfrc522/mfrc522.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/devices/lirc/lirc.go b/devices/lirc/lirc.go index dc6dfa0..753915f 100644 --- a/devices/lirc/lirc.go +++ b/devices/lirc/lirc.go @@ -131,6 +131,9 @@ func (c *Conn) readData(r *bufio.Reader) error { switch cmd { case "SIGHUP": _, err = c.w.Write([]byte("LIST\n")) + if err != nil { + return err + } default: // In case of any error, ignore the rest. line, err := read(r) diff --git a/experimental/devices/mfrc522/mfrc522.go b/experimental/devices/mfrc522/mfrc522.go index 59f6b53..de9e32d 100644 --- a/experimental/devices/mfrc522/mfrc522.go +++ b/experimental/devices/mfrc522/mfrc522.go @@ -384,7 +384,7 @@ func (r *Dev) write(blockAddr byte, data []byte) error { if backLen != 4 || read[0]&0x0F != 0x0A { err = wrapf("can't write data") } - return nil + return err } // preAccess calculates CRC of the block address to be accessed and sends it to the device for verification.