From b8dde0ed4349ce54a9d53a0b6149a6ddf9f77d53 Mon Sep 17 00:00:00 2001 From: Marc-Antoine Ruel Date: Wed, 23 Dec 2020 16:14:59 -0500 Subject: [PATCH] Fix all gosec G104 warnings This will be enforced in a follow up commit. --- experimental/devices/epd/epd.go | 20 +++++++++++++++----- experimental/devices/tlv493d/tlv493d.go | 4 +++- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/experimental/devices/epd/epd.go b/experimental/devices/epd/epd.go index 1450e94..9228f8b 100644 --- a/experimental/devices/epd/epd.go +++ b/experimental/devices/epd/epd.go @@ -199,13 +199,17 @@ func (d *Dev) Draw(r image.Rectangle, src image.Image, sp image.Point) error { yEnd = h - 1 } - d.setMemoryArea(xStart, yStart, xEnd, yEnd) + if err := d.setMemoryArea(xStart, yStart, xEnd, yEnd); err != nil { + return err + } next := image1bit.NewVerticalLSB(d.rect) draw.Src.Draw(next, r, src, sp) var byteToSend byte = 0x00 for y := yStart; y < yEnd+1; y++ { - d.setMemoryPointer(xStart, y) + if err := d.setMemoryPointer(xStart, y); err != nil { + return err + } if err := d.sendCommand([]byte{writeRAM}); err != nil { return err } @@ -231,8 +235,12 @@ func (d *Dev) Draw(r image.Rectangle, src image.Image, sp image.Point) error { func (d *Dev) ClearFrameMemory(color byte) error { w := d.rect.Dx() h := d.rect.Dy() - d.setMemoryArea(0, 0, w-1, h-1) - d.setMemoryPointer(0, 0) + if err := d.setMemoryArea(0, 0, w-1, h-1); err != nil { + return err + } + if err := d.setMemoryPointer(0, 0); err != nil { + return err + } if err := d.sendCommand([]byte{writeRAM}); err != nil { return err } @@ -440,7 +448,9 @@ func (d *Dev) setLut(update PartialUpdate) error { } for i := range lut { - d.sendData([]byte{lut[i]}) + if err := d.sendData([]byte{lut[i]}); err != nil { + return err + } } return nil } diff --git a/experimental/devices/tlv493d/tlv493d.go b/experimental/devices/tlv493d/tlv493d.go index 7f3c292..2925cff 100644 --- a/experimental/devices/tlv493d/tlv493d.go +++ b/experimental/devices/tlv493d/tlv493d.go @@ -379,7 +379,9 @@ func (d *Dev) ReadContinuous(frequency physic.Frequency, precision Precision) (< } previousMode := d.mode - d.SetMode(newMode) + if err := d.SetMode(newMode); err != nil { + return nil, err + } t := time.NewTicker(frequency.Period())