gpio: Rename Edge constants. (#103)

This is to make the value more readable at the call site.
pull/1/head
M-A 10 years ago committed by Thorsten von Eicken
parent 3368c35ef7
commit 2d5524c4cb

@ -168,7 +168,7 @@ func (d *Dev) writeByte(b byte) (bool, error) {
d.data.Out(gpio.Low) d.data.Out(gpio.Low)
time.Sleep(clockHalfCycle) time.Sleep(clockHalfCycle)
// TODO(maruel): Add. // TODO(maruel): Add.
//if err := d.data.In(gpio.PullUp, gpio.None); err != nil { //if err := d.data.In(gpio.PullUp, gpio.NoEdge); err != nil {
// return false, err // return false, err
//} //}
d.clk.Out(gpio.High) d.clk.Out(gpio.High)

@ -118,14 +118,14 @@ func (i *I2C) SDA() gpio.PinIO {
func New(clk gpio.PinIO, data gpio.PinIO, speedHz int) (*I2C, error) { func New(clk gpio.PinIO, data gpio.PinIO, speedHz int) (*I2C, error) {
// Spec calls to idle at high. Page 8, section 3.1.1. // Spec calls to idle at high. Page 8, section 3.1.1.
// Set SCL as pull-up. // Set SCL as pull-up.
if err := clk.In(gpio.PullUp, gpio.None); err != nil { if err := clk.In(gpio.PullUp, gpio.NoEdge); err != nil {
return nil, err return nil, err
} }
if err := clk.Out(gpio.High); err != nil { if err := clk.Out(gpio.High); err != nil {
return nil, err return nil, err
} }
// Set SDA as pull-up. // Set SDA as pull-up.
if err := data.In(gpio.PullUp, gpio.None); err != nil { if err := data.In(gpio.PullUp, gpio.NoEdge); err != nil {
return nil, err return nil, err
} }
if err := data.Out(gpio.High); err != nil { if err := data.Out(gpio.High); err != nil {
@ -196,11 +196,11 @@ func (i *I2C) writeByte(b byte) (bool, error) {
// 9th clock is ACK. // 9th clock is ACK.
i.sleepHalfCycle() i.sleepHalfCycle()
// SCL was already set as pull-up. PullNoChange // SCL was already set as pull-up. PullNoChange
if err := i.scl.In(gpio.PullUp, gpio.None); err != nil { if err := i.scl.In(gpio.PullUp, gpio.NoEdge); err != nil {
return false, err return false, err
} }
// SDA was already set as pull-up. // SDA was already set as pull-up.
if err := i.sda.In(gpio.PullUp, gpio.None); err != nil { if err := i.sda.In(gpio.PullUp, gpio.NoEdge); err != nil {
return false, err return false, err
} }
// Implement clock stretching, the device may keep the line low. // Implement clock stretching, the device may keep the line low.
@ -227,7 +227,7 @@ func (i *I2C) writeByte(b byte) (bool, error) {
// Lasts 9 cycles. // Lasts 9 cycles.
func (i *I2C) readByte() (byte, error) { func (i *I2C) readByte() (byte, error) {
var b byte var b byte
if err := i.sda.In(gpio.PullUp, gpio.None); err != nil { if err := i.sda.In(gpio.PullUp, gpio.NoEdge); err != nil {
return b, err return b, err
} }
for x := 0; x < 8; x++ { for x := 0; x < 8; x++ {

@ -138,7 +138,7 @@ func NewSPI(clk, mosi gpio.PinOut, miso gpio.PinIn, cs gpio.PinOut, speedHz int6
return nil, err return nil, err
} }
if miso != nil { if miso != nil {
if err := miso.In(gpio.PullUp, gpio.None); err != nil { if err := miso.In(gpio.PullUp, gpio.NoEdge); err != nil {
return nil, err return nil, err
} }
} }

Loading…
Cancel
Save