cleanup and docu fix for ds18b20

pull/19/head
Benjamin Böhmke 5 years ago
parent a1c8b55557
commit 2f7d325043

@ -21,7 +21,8 @@
// Datasheets // Datasheets
// //
// https://datasheets.maximintegrated.com/en/ds/DS18B20-PAR.pdf // https://datasheets.maximintegrated.com/en/ds/DS18B20-PAR.pdf
//
// https://datasheets.maximintegrated.com/en/ds/DS18S20.pdf // https://datasheets.maximintegrated.com/en/ds/DS18S20.pdf
// //
// http://datasheets.maximintegrated.com/en/ds/MAX31820.pdf // https://datasheets.maximintegrated.com/en/ds/MAX31820.pdf
package ds18b20 package ds18b20

@ -190,12 +190,6 @@ func (d *Dev) parseTemperature(spad []byte) physic.Temperature {
// calculation from http://myarduinotoy.blogspot.com/2013/02/12bit-result-from-ds18s20.html // calculation from http://myarduinotoy.blogspot.com/2013/02/12bit-result-from-ds18s20.html
mask := 0xFFFE mask := 0xFFFE
rawTemp = ((rawTemp & int16(mask)) << 3) + 12 - int16(spad[6]) rawTemp = ((rawTemp & int16(mask)) << 3) + 12 - int16(spad[6])
//rawTemp = rawTemp/2 // truncated last bit (0,5°C)
//rawTemp <<= 4 // convert to 12 bit precision (rawTemp is now in 1/16 °C)
//rawTemp = rawTemp-4 + (int16(spad[7])*16 - int16(spad[6])*16)/int16(spad[7])
//rawTemp += int16(16 - spad[6] - 4) // add compensation and remove 0.25 °C (4/16)
} }
// rawTemp has 4 fractional bits. Need to do sign extension multiply by // rawTemp has 4 fractional bits. Need to do sign extension multiply by
// 1000 to get Millis, divide by 16 due to 4 fractional bits. Datasheet p.4. // 1000 to get Millis, divide by 16 due to 4 fractional bits. Datasheet p.4.

Loading…
Cancel
Save