mirror of https://github.com/periph/devices
bmp180: promote to stable; fix bug in bme280 (#152)
- bme280: fix hang in Halt() if SenseContinuous() listener is hung. - bmp180: Add unit tests; increase test coverage to 96%. - bmp180: Remove Reset(). There's no known use case. - bmp180: Implement SenseContinuous(). - Consistently wrap errors in both packages. - Various typos.pull/1/head
M-A
9 years ago
committed by
GitHub
parent
e235d09bc8
commit
70fd9082bb
@ -0,0 +1,362 @@
|
||||
// Copyright 2017 The Periph Authors. All rights reserved.
|
||||
// Use of this source code is governed under the Apache License, Version 2.0
|
||||
// that can be found in the LICENSE file.
|
||||
|
||||
package bmp180
|
||||
|
||||
import (
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"periph.io/x/periph/conn/i2c/i2ctest"
|
||||
"periph.io/x/periph/devices"
|
||||
)
|
||||
|
||||
func TestNew_fail_read_chipid(t *testing.T) {
|
||||
bus := i2ctest.Playback{
|
||||
Ops: []i2ctest.IO{
|
||||
// Chip ID detection read fail.
|
||||
},
|
||||
DontPanic: true,
|
||||
}
|
||||
if _, err := New(&bus, O1x); err == nil {
|
||||
t.Fatal("can't read chip ID")
|
||||
}
|
||||
}
|
||||
|
||||
func TestNew_bad_chipid(t *testing.T) {
|
||||
bus := i2ctest.Playback{
|
||||
Ops: []i2ctest.IO{
|
||||
// Bad Chip ID detection.
|
||||
{Addr: 0x77, W: []byte{0xd0}, R: []byte{0x60}},
|
||||
},
|
||||
}
|
||||
if _, err := New(&bus, O1x); err == nil {
|
||||
t.Fatal("bad chip ID")
|
||||
}
|
||||
}
|
||||
|
||||
func TestNew_fail_calib(t *testing.T) {
|
||||
bus := i2ctest.Playback{
|
||||
Ops: []i2ctest.IO{
|
||||
// Chip ID detection.
|
||||
{Addr: 0x77, W: []byte{0xd0}, R: []byte{0x55}},
|
||||
// Fail to read calibration data.
|
||||
},
|
||||
DontPanic: true,
|
||||
}
|
||||
if _, err := New(&bus, O1x); err == nil {
|
||||
t.Fatal("can't read calibration")
|
||||
}
|
||||
}
|
||||
|
||||
func TestNew_bad_calib(t *testing.T) {
|
||||
bus := i2ctest.Playback{
|
||||
Ops: []i2ctest.IO{
|
||||
// Chip ID detection.
|
||||
{Addr: 0x77, W: []byte{0xd0}, R: []byte{0x55}},
|
||||
// Calibration data.
|
||||
{
|
||||
Addr: 0x77,
|
||||
W: []byte{0xaa},
|
||||
R: []byte{255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255},
|
||||
},
|
||||
},
|
||||
DontPanic: true,
|
||||
}
|
||||
if _, err := New(&bus, O1x); err == nil {
|
||||
t.Fatal("bad calibration")
|
||||
}
|
||||
}
|
||||
|
||||
func TestSense_success(t *testing.T) {
|
||||
bus := i2ctest.Playback{
|
||||
Ops: []i2ctest.IO{
|
||||
// Chip ID detection.
|
||||
{Addr: 0x77, W: []byte{0xd0}, R: []byte{0x55}},
|
||||
// Calibration data.
|
||||
{
|
||||
Addr: 0x77,
|
||||
W: []byte{0xaa},
|
||||
R: []byte{35, 136, 251, 103, 199, 169, 135, 91, 98, 137, 80, 22, 25, 115, 0, 46, 128, 0, 209, 246, 10, 123},
|
||||
},
|
||||
// Request temperature.
|
||||
{Addr: 0x77, W: []byte{0xF4, 0x2E}},
|
||||
// Read temperature.
|
||||
{Addr: 0x77, W: []byte{0xF6}, R: []byte{0x71, 0xBf}},
|
||||
// Request pressure.
|
||||
{Addr: 0x77, W: []byte{0xF4, 0x34}},
|
||||
// Read pressure.
|
||||
{Addr: 0x77, W: []byte{0xF6}, R: []byte{0xAb, 0x96, 0}},
|
||||
},
|
||||
}
|
||||
dev, err := New(&bus, O1x)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if s := dev.String(); s != "BMP180{playback(119)}" {
|
||||
t.Fatal(s)
|
||||
}
|
||||
env := devices.Environment{}
|
||||
if err := dev.Sense(&env); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if env.Temperature != 25300 {
|
||||
t.Fatalf("temp %d", env.Temperature)
|
||||
}
|
||||
if env.Pressure != 100567 {
|
||||
t.Fatalf("pressure %d", env.Pressure)
|
||||
}
|
||||
if env.Humidity != 0 {
|
||||
t.Fatalf("humidity %d", env.Humidity)
|
||||
}
|
||||
if err := dev.Halt(); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := bus.Close(); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestSense_fail_1(t *testing.T) {
|
||||
bus := i2ctest.Playback{
|
||||
Ops: []i2ctest.IO{
|
||||
// Chip ID detection.
|
||||
{Addr: 0x77, W: []byte{0xd0}, R: []byte{0x55}},
|
||||
// Calibration data.
|
||||
{
|
||||
Addr: 0x77,
|
||||
W: []byte{0xaa},
|
||||
R: []byte{35, 136, 251, 103, 199, 169, 135, 91, 98, 137, 80, 22, 25, 115, 0, 46, 128, 0, 209, 246, 10, 123},
|
||||
},
|
||||
// Request temperature fail.
|
||||
},
|
||||
DontPanic: true,
|
||||
}
|
||||
dev, err := New(&bus, O1x)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
env := devices.Environment{}
|
||||
if dev.Sense(&env) == nil {
|
||||
t.Fatal("sensing should have failed")
|
||||
}
|
||||
if err := bus.Close(); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestSense_fail_2(t *testing.T) {
|
||||
bus := i2ctest.Playback{
|
||||
Ops: []i2ctest.IO{
|
||||
// Chip ID detection.
|
||||
{Addr: 0x77, W: []byte{0xd0}, R: []byte{0x55}},
|
||||
// Calibration data.
|
||||
{
|
||||
Addr: 0x77,
|
||||
W: []byte{0xaa},
|
||||
R: []byte{35, 136, 251, 103, 199, 169, 135, 91, 98, 137, 80, 22, 25, 115, 0, 46, 128, 0, 209, 246, 10, 123},
|
||||
},
|
||||
// Request temperature.
|
||||
{Addr: 0x77, W: []byte{0xF4, 0x2E}},
|
||||
// Read temperature fail.
|
||||
},
|
||||
DontPanic: true,
|
||||
}
|
||||
dev, err := New(&bus, O1x)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
env := devices.Environment{}
|
||||
if dev.Sense(&env) == nil {
|
||||
t.Fatal("sensing should have failed")
|
||||
}
|
||||
if err := bus.Close(); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestSense_fail_3(t *testing.T) {
|
||||
bus := i2ctest.Playback{
|
||||
Ops: []i2ctest.IO{
|
||||
// Chip ID detection.
|
||||
{Addr: 0x77, W: []byte{0xd0}, R: []byte{0x55}},
|
||||
// Calibration data.
|
||||
{
|
||||
Addr: 0x77,
|
||||
W: []byte{0xaa},
|
||||
R: []byte{35, 136, 251, 103, 199, 169, 135, 91, 98, 137, 80, 22, 25, 115, 0, 46, 128, 0, 209, 246, 10, 123},
|
||||
},
|
||||
// Request temperature.
|
||||
{Addr: 0x77, W: []byte{0xF4, 0x2E}},
|
||||
// Read temperature fail.
|
||||
{Addr: 0x77, W: []byte{0xF6}, R: []byte{0x71, 0xBf}},
|
||||
// Request pressure fail.
|
||||
},
|
||||
DontPanic: true,
|
||||
}
|
||||
dev, err := New(&bus, O1x)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
env := devices.Environment{}
|
||||
if dev.Sense(&env) == nil {
|
||||
t.Fatal("sensing should have failed")
|
||||
}
|
||||
if err := bus.Close(); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestSense_fail_4(t *testing.T) {
|
||||
bus := i2ctest.Playback{
|
||||
Ops: []i2ctest.IO{
|
||||
// Chip ID detection.
|
||||
{Addr: 0x77, W: []byte{0xd0}, R: []byte{0x55}},
|
||||
// Calibration data.
|
||||
{
|
||||
Addr: 0x77,
|
||||
W: []byte{0xaa},
|
||||
R: []byte{35, 136, 251, 103, 199, 169, 135, 91, 98, 137, 80, 22, 25, 115, 0, 46, 128, 0, 209, 246, 10, 123},
|
||||
},
|
||||
// Request temperature.
|
||||
{Addr: 0x77, W: []byte{0xF4, 0x2E}},
|
||||
// Read temperature fail.
|
||||
{Addr: 0x77, W: []byte{0xF6}, R: []byte{0x71, 0xBf}},
|
||||
// Request pressure.
|
||||
{Addr: 0x77, W: []byte{0xF4, 0x34}},
|
||||
// Read pressure fail.
|
||||
},
|
||||
DontPanic: true,
|
||||
}
|
||||
dev, err := New(&bus, O1x)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
env := devices.Environment{}
|
||||
if dev.Sense(&env) == nil {
|
||||
t.Fatal("sensing should have failed")
|
||||
}
|
||||
if err := bus.Close(); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestSenseContinuous_success(t *testing.T) {
|
||||
bus := i2ctest.Playback{
|
||||
Ops: []i2ctest.IO{
|
||||
// Chip ID detection.
|
||||
{Addr: 0x77, W: []byte{0xd0}, R: []byte{0x55}},
|
||||
// Calibration data.
|
||||
{
|
||||
Addr: 0x77,
|
||||
W: []byte{0xaa},
|
||||
R: []byte{35, 136, 251, 103, 199, 169, 135, 91, 98, 137, 80, 22, 25, 115, 0, 46, 128, 0, 209, 246, 10, 123},
|
||||
},
|
||||
// Request temperature.
|
||||
{Addr: 0x77, W: []byte{0xF4, 0x2E}},
|
||||
// Read temperature.
|
||||
{Addr: 0x77, W: []byte{0xF6}, R: []byte{0x71, 0xBf}},
|
||||
// Request pressure.
|
||||
{Addr: 0x77, W: []byte{0xF4, 0x34}},
|
||||
// Read pressure.
|
||||
{Addr: 0x77, W: []byte{0xF6}, R: []byte{0xAb, 0x96, 0}},
|
||||
// Request temperature.
|
||||
{Addr: 0x77, W: []byte{0xF4, 0x2E}},
|
||||
// Read temperature.
|
||||
{Addr: 0x77, W: []byte{0xF6}, R: []byte{0x71, 0xBf}},
|
||||
// Request pressure.
|
||||
{Addr: 0x77, W: []byte{0xF4, 0x34}},
|
||||
// Read pressure.
|
||||
{Addr: 0x77, W: []byte{0xF6}, R: []byte{0xAb, 0x96, 0}},
|
||||
},
|
||||
DontPanic: true,
|
||||
}
|
||||
dev, err := New(&bus, O1x)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
c, err := dev.SenseContinuous(time.Minute)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
env := <-c
|
||||
if env.Temperature != 25300 {
|
||||
t.Fatalf("temp %d", env.Temperature)
|
||||
}
|
||||
if env.Pressure != 100567 {
|
||||
t.Fatalf("pressure %d", env.Pressure)
|
||||
}
|
||||
if env.Humidity != 0 {
|
||||
t.Fatalf("humidity %d", env.Humidity)
|
||||
}
|
||||
|
||||
if dev.Sense(&env) == nil {
|
||||
t.Fatal("Sense() should have failed")
|
||||
}
|
||||
|
||||
c2, err := dev.SenseContinuous(time.Minute)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
env = <-c2
|
||||
|
||||
if _, ok := <-c; ok {
|
||||
t.Fatal("c should be closed")
|
||||
}
|
||||
|
||||
if err := dev.Halt(); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, ok := <-c2; ok {
|
||||
t.Fatal("c2 should be closed")
|
||||
}
|
||||
|
||||
if err := bus.Close(); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestOversampling(t *testing.T) {
|
||||
data := []struct {
|
||||
o Oversampling
|
||||
v int
|
||||
s string
|
||||
}{
|
||||
{O1x, 1, "1x"},
|
||||
{O2x, 2, "2x"},
|
||||
{O4x, 4, "4x"},
|
||||
{O8x, 8, "8x"},
|
||||
{Oversampling(100), 0, "Oversampling(100)"},
|
||||
}
|
||||
for i, line := range data {
|
||||
if s := line.o.String(); s != line.s {
|
||||
t.Fatalf("#%d %s != %s", i, s, line.s)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestCompensate(t *testing.T) {
|
||||
c := calibration{
|
||||
AC1: 408,
|
||||
AC2: -72,
|
||||
AC3: -14383,
|
||||
AC4: 32741,
|
||||
AC5: 32757,
|
||||
AC6: 23153,
|
||||
B1: 6190,
|
||||
B2: 4,
|
||||
MB: -32768,
|
||||
MC: -8711,
|
||||
MD: 2868,
|
||||
}
|
||||
|
||||
if temp := c.compensateTemp(27898); temp != 150 {
|
||||
t.Errorf("temperature is wrong, want %v, got %v", 150, temp)
|
||||
}
|
||||
|
||||
if pressure := c.compensatePressure(23843, 27898, 0); pressure != 69964 {
|
||||
t.Errorf("pressure is wrong, want %v, got %v", 69964, pressure)
|
||||
}
|
||||
}
|
||||
@ -1,31 +0,0 @@
|
||||
// Copyright 2017 The Periph Authors. All rights reserved.
|
||||
// Use of this source code is governed under the Apache License, Version 2.0
|
||||
// that can be found in the LICENSE file.
|
||||
|
||||
package bmp180
|
||||
|
||||
import "testing"
|
||||
|
||||
func TestCompensate(t *testing.T) {
|
||||
c := calibration{
|
||||
AC1: 408,
|
||||
AC2: -72,
|
||||
AC3: -14383,
|
||||
AC4: 32741,
|
||||
AC5: 32757,
|
||||
AC6: 23153,
|
||||
B1: 6190,
|
||||
B2: 4,
|
||||
MB: -32768,
|
||||
MC: -8711,
|
||||
MD: 2868,
|
||||
}
|
||||
|
||||
if temp := c.compensateTemp(27898); temp != 150 {
|
||||
t.Errorf("temperature is wrong, want %v, got %v", 150, temp)
|
||||
}
|
||||
|
||||
if pressure := c.compensatePressure(23843, 27898, 0); pressure != 69964 {
|
||||
t.Errorf("pressure is wrong, want %v, got %v", 69964, pressure)
|
||||
}
|
||||
}
|
||||
Loading…
Reference in New Issue