Add shell check to pre-commit

.pre-commit-config.yaml

@@ -1,5 +1,9 @@
 default_stages: [commit, push]
 repos:
+  - repo: https://github.com/shellcheck-py/shellcheck-py
+    rev: v0.8.0.4
+    hooks:
+      - id: shellcheck
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v3.2.0
     hooks:

README.md

@@ -2,6 +2,8 @@
 
 Learning distributed task queues by doing. Since it's a greenfield project this also uses a newer async web framework.
 
+See: [Celery docs](https://celery-safwan.readthedocs.io/en/latest/index.html)
+
 ## Debugging Celery
 
 ### Check results in redis result backend

compose/local/fastapi/celery/worker/start.sh

@@ -6,7 +6,7 @@ set -o nounset
 # Use watchfiles during development
 CELERY_WORKER_WATCH=${CELERY_WORKER_WATCH:-}
 
-if [ ! -z $CELERY_WORKER_WATCH ]; then
+if [ -n "${CELERY_WORKER_WATCH}" ]; then
     watchfiles --filter python 'celery -A main.celery worker --loglevel=info'
 else
    exec python -m celery -A main.celery worker --loglevel=info

dev-requirements.in

@@ -5,3 +5,4 @@ pip-tools==6.8.0
 pre-commit==2.20.0
 pylint==2.15.2
 pytest==7.1.3
+shellcheck-py==0.8.0.4

dev-requirements.txt

@@ -77,6 +77,8 @@ pytest==7.1.3
     # via -r dev-requirements.in
 pyyaml==6.0
     # via pre-commit
+shellcheck-py==0.8.0.4
+    # via -r dev-requirements.in
 toml==0.10.2
     # via pre-commit
 tomli==2.0.1

requirements.in

@@ -4,6 +4,7 @@ fastapi==0.79.0
 flower==1.2.0
 psycopg2-binary==2.9.3
 redis==4.3.4
+shellcheck-py==0.8.0.4
 SQLAlchemy==1.4.40
 uvicorn[standard]==0.18.2
 watchfiles==0.17.0